Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: KV tutorial becomes usage doc #20994

Merged
merged 2 commits into from
Apr 18, 2024
Merged

docs: KV tutorial becomes usage doc #20994

merged 2 commits into from
Apr 18, 2024

Conversation

boruszak
Copy link
Contributor

@boruszak boruszak commented Apr 18, 2024 •
edited
Loading

Description

This PR is a minor change to support the Consul Tutorial Refresh.

When testing redirects, we noticed a circular loop: the deprecated KV store tutorial redirected to the KV overview page, but the KV overview page linked to the tutorial for its usage info.

We had already made a docs version of the tutorial for the docs refresh, so we're adding it to the docs now and fixing the redirect in the tutorials repo to create a less frustrating experience.

Deployment preview

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Apr 18, 2024
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. backport/1.18 labels Apr 18, 2024
@boruszak boruszak marked this pull request as ready for review April 18, 2024 17:33
@boruszak boruszak requested a review from a team as a code owner April 18, 2024 17:33
@boruszak boruszak merged commit d106c7f into main Apr 18, 2024
61 checks passed
@boruszak boruszak deleted the docs/tutorial-refresh-support branch April 18, 2024 17:50
This was referenced Apr 18, 2024
Closed
Closed
Merged
Merged
boruszak added a commit that referenced this pull request Apr 18, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
8490c4a 
* Add KV store usage page

* nav typo
boruszak added a commit that referenced this pull request Apr 18, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
9a8b8a2 
* Add KV store usage page

* nav typo
@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

3 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

krastin added a commit that referenced this pull request Apr 22, 2024
@krastin
reintroduce nav from #20873 and #20994
00bb6ab
krastin added a commit that referenced this pull request Apr 22, 2024
@boruszak @rkoron007 @krastin
docs: Initial HCP Rebrand (#21000)
057ad7e 
* Initial rebrand for HCP Terraform

* Apply suggestions from code review

Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>

* path fix and redirect

* reintroduce nav from #20873 and #20994

---------

Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Krastin Krastev <krastin@hashicorp.com>
boruszak added a commit that referenced this pull request Apr 22, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
fd2c298 
* Add KV store usage page

* nav typo
boruszak added a commit that referenced this pull request Apr 22, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
6d44e96 
* Add KV store usage page

* nav typo
boruszak added a commit that referenced this pull request Apr 22, 2024
@boruszak
docs: manual backport of KV docs conversion to v1.16.x (#21006)
ef01dc1 
docs: KV tutorial becomes usage doc (#20994)

* Add KV store usage page

* nav typo
boruszak added a commit that referenced this pull request Apr 22, 2024
@boruszak
docs: manual backport of KV tutorial becomes usage doc (#20994) (#21007)
a75d93e 
docs: KV tutorial becomes usage doc (#20994)

* Add KV store usage page

* nav typo
@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@boruszak, a backport is missing for this PR [20994] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@boruszak boruszak removed backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Apr 25, 2024
boruszak added a commit that referenced this pull request Apr 26, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
f434f13 
* Add KV store usage page

* nav typo
@boruszak boruszak mentioned this pull request Apr 26, 2024
Closed
3 tasks
boruszak added a commit that referenced this pull request Apr 26, 2024
@boruszak
docs: KV tutorial becomes usage doc (#20994)
07898ac 
* Add KV store usage page

* nav typo
@boruszak boruszak mentioned this pull request Apr 26, 2024
Closed
3 tasks
This was referenced Sep 26, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

Assignees
No one assigned
Labels
backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boruszak @hc-github-team-consul-core @david-yu